Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sessions): add last start time to UI table for sessions #5481

Merged
merged 2 commits into from
Nov 25, 2024
Merged

feat(sessions): add last start time to UI table for sessions #5481

merged 2 commits into from
Nov 25, 2024

Conversation

RogerHYang
Copy link
Contributor

resolves #5356

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 21, 2024
@RogerHYang RogerHYang linked an issue Nov 21, 2024 that may be closed by this pull request
[sessions][ui] add last_start_time to sessions table columns #5356
Closed
axiomofjoy
axiomofjoy approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@axiomofjoy axiomofjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort of wonder if "last trace time" might be a clearer name for the column

@RogerHYang RogerHYang force-pushed the sessions2 branch 2 times, most recently from bfb3edb to f180329 Compare November 25, 2024 20:07
@RogerHYang
Copy link
Contributor Author

sort of wonder if "last trace time" might be a clearer name for the column

renamed as "last trace start time"

@RogerHYang RogerHYang merged commit a2ebd8a into sessions2 Nov 25, 2024
27 checks passed
@RogerHYang RogerHYang deleted the 5356-last-start-time branch November 25, 2024 21:00
RogerHYang added a commit that referenced this pull request Nov 26, 2024
@RogerHYang
feat(sessions): add last trace start time column to UI table for sess…
1957432 
…ions (#5481)
RogerHYang added a commit that referenced this pull request Dec 2, 2024
@RogerHYang
feat(sessions): add last trace start time column to UI table for sess…
35b1069 
…ions (#5481)
This was referenced Dec 3, 2024
Merged
Closed
RogerHYang added a commit that referenced this pull request Dec 4, 2024
@RogerHYang
feat(sessions): add last trace start time column to UI table for sess…
76dcc55 
…ions (#5481)
RogerHYang added a commit that referenced this pull request Dec 4, 2024
@RogerHYang
feat(sessions): add last trace start time column to UI table for sess…
0b402db 
…ions (#5481)
RogerHYang added a commit that referenced this pull request Dec 9, 2024
@RogerHYang
feat(sessions): add last trace start time column to UI table for sess…
33767f6 
…ions (#5481)
RogerHYang added a commit that referenced this pull request Dec 9, 2024
@RogerHYang
feat(sessions): add last trace start time column to UI table for sess…
d300c2b 
…ions (#5481)
RogerHYang added a commit that referenced this pull request Dec 9, 2024
@RogerHYang
feat(sessions): add last trace start time column to UI table for sess…
f0152bb 
…ions (#5481)
RogerHYang added a commit that referenced this pull request Dec 9, 2024
@RogerHYang
feat(sessions): add last trace start time column to UI table for sess…
567c901 
…ions (#5481)
@mikeldking mikeldking mentioned this pull request Dec 9, 2024
Merged
mikeldking pushed a commit that referenced this pull request Dec 11, 2024
@RogerHYang @mikeldking
feat(sessions): add last trace start time column to UI table for sess…
a8aa03f 
…ions (#5481)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axiomofjoy axiomofjoy axiomofjoy approved these changes

Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
phoenix
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sessions][ui] add last_start_time to sessions table columns
2 participants
@RogerHYang @axiomofjoy